search

ProofSuite / OrFeed

DeFi & Distributed Data Service Aggregator
https://www.orfeed.org
Apache License 2.0
241 stars 152 forks source link

traderExampleLesson2.sol orfeed.getExchangeRate for Kyber exchange always returns zero #76

Closed olegmitrakhovich closed 3 years ago

olegmitrakhovich commented 4 years ago

I've been trying to test out traderExampleLesson2.sol and I noticed that

function getKyberBuyPrice() constant returns (uint256){ //change this to SAI uint256 currentPrice = orfeed.getExchangeRate("ETH", "SAI", "BUY-KYBER-EXCHANGE", 1000000000000000000); return currentPrice; }

Probably will not work once the contract is deployed. It always returns zero when that function is tried on etherscan when the parameters applied: https://etherscan.io/address/0x8316b082621cfedab95bf4a44a1d4b64a6ffc336#readContract

Is something wrong with orfeed contract?

(when requesting price from uniswap that works fine)

Vamsee30 commented 3 years ago

The ether address Mike put is '0x00eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee'

This is wrong, it should be: '0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee'

Second, the DAI address should be 0x6b175474e89094c44da98b954eedeac495271d0f