search

ProofSuite / OrFeed

DeFi & Distributed Data Service Aggregator
https://www.orfeed.org
Apache License 2.0
241 stars 152 forks source link

Reorganize example folder and add a python example #80

Open edd34 opened 3 years ago

edd34 commented 3 years ago

I moved nodeJSAppExamples into "./examples/nodeJS" without changing folder structure or anything in the project. I have added a project called oracle_arb_finder into "./examples/python" folder.

edd34 commented 3 years ago

A demo where I arb ETH/ZRX on Uniswap/Kyberswap https://youtu.be/0Yg_OdEhgNI

mikedeshazer commented 3 years ago

@edd34 the greatest issue with the merge is that there are many videos and other content that reference the nodejs example endpoints, so changing this would break those links and lead to a number of complaints (most likely). If you could resubmit a PR keeping file structure the same, we can merge this! Thanks for your contribution!

edd34 commented 3 years ago

@edd34 the greatest issue with the merge is that there are many videos and other content that reference the nodejs example endpoints, so changing this would break those links and lead to a number of complaints (most likely). If you could resubmit a PR keeping file structure the same, we can merge this! Thanks for your contribution!

Hello @mikedeshazer I revert the commit which moved the files from NodeJSAppExamples and I have inserted some comments and code formating along the way.

kennisnutz commented 3 years ago

@edd34 how can I get better at using the orfeed Package, Im new to programing but I understood mikes series very well and i want to explore any chance we can collaborate on something? will help me learn faster

edd34 commented 3 years ago

@edd34 how can I get better at using the orfeed Package, Im new to programing but I understood mikes series very well and i want to explore any chance we can collaborate on something? will help me learn faster

In order to ramp up quickly, try to use web3 and query the blockchain via OrFeed for prices. Create a project and tag me on issue or PR @edd34 I'll review your code

kennisnutz commented 3 years ago

In order to ramp up quickly, try to use web3 and query the blockchain via OrFeed for prices. Create a project and tag me on issue or PR @edd34 I'll review your code

ok well thank you I will do this within the next week