ProofSuite / OrFeed

DeFi & Distributed Data Service Aggregator
https://www.orfeed.org
Apache License 2.0
241 stars 152 forks source link

Cloning fails on Windows due to whitespace in path #81

Open danbunnell opened 3 years ago

danbunnell commented 3 years ago

Hi,

I was attempting to clone this repository on Windows but checkout fails due to whitespace at the end of a folder name: nodeJSAppExamples/basicArbExample /.gitignore. I have included the full error below.

The temp workaround is to download the ZIP: Windows appears to handle unpacking the ZIP by removing the whitespace silently during the process. However, the workaround does not help to get a local Windows branch in sync with the remote. Manually configuring a remote still throws errors when attempting to checkout.

Can you fix the basicArbExample path for Windows users?

Thanks, Dan

PS D:\repos> git clone https://github.com/ProofSuite/OrFeed.git
Cloning into 'OrFeed'...
remote: Enumerating objects: 264, done.
remote: Counting objects: 100% (264/264), done.
remote: Compressing objects: 100% (159/159), done.
Receiving objects:  91% (991/1088)used 193 (delta 101), pack-reused 824 eceiving objects:  88% (958/1088)
Receiving objects: 100% (1088/1088), 487.73 KiB | 1.83 MiB/s, done.
Resolving deltas: 100% (612/612), done.
error: invalid path 'nodeJSAppExamples/basicArbExample /.gitignore'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
edd34 commented 3 years ago

Hi, I have pushed a fix for this issue @danbunnell Please try the solution I have suggested

danbunnell commented 3 years ago

@edd34 I have confirmed your PR fixes the issue on Windows, thank you!