search

Proryanator / encoder-benchmark

A tool to benchmark your hardware's real-time video encoding capabilities.
GNU General Public License v3.0
63 stars 5 forks source link

Docker support #48

Open Proryanator opened 9 months ago

Proryanator commented 9 months ago

Would be nice if both the tool itself, as well as the downloading of the source files had some docker support.

The more ways people can easily run this tool the more accessible it will be.

e-dong commented 9 months ago

I do a lot of docker stuff at work, so I could potentially help with this unless you want to do it. What kind of base image did you have in mind? Most docker images are based off of Linux images. We could also compile various Linux binaries in the containers for release assets. This would be simpler than trying to set up VMs.

Do you mind clarifying on using docker to download source files?

Proryanator commented 9 months ago

You can give it a shot! So long as you have a Windows machine to test it out on too 😊 Just that the docker container should auto download the files while it runs, so that may even just be an update to the cli tools themselves (not really docker specific).

But that way when you go to run the container that's all you need to do.

As for base images yea some linux based one would be fine, maybe a lightweight one. Ideally ffmpeg and other requirmenentd would be there, and work well with using your GPUs on Linux/Windows (i.e. docker be able to see your host GPU and use it). That may be the challenging bit but I think that's been done before.

e-dong commented 9 months ago

I dual boot with windows so I can test that! Ohh gotcha, that makes sense. Maybe there should be a separate issue for auto downloading the files.

I'm familiar with Nvidia GPU, but I don't have an AMD GPU to test with. I can focus on nvidia for now. windows: WSL2 https://www.docker.com/blog/wsl-2-gpu-support-is-here/ Linux: nvidia-docker https://github.com/NVIDIA/nvidia-container-toolkit

Base image I was thinking of using cuda: https://hub.docker.com/r/nvidia/cuda/tags Not sure lightweight is possible because of cuda haha

Proryanator commented 8 months ago

That sounds good to me! Go for it! I can build off what you make for Nvidia and we can round it out 👍

mcam10 commented 2 weeks ago

Anybody pick this up yet? Just found this repo cus I wanted to put my Nvidia Jetson's to the test.. but the support for Docker would be nice.

Proryanator commented 2 weeks ago

Anybody pick this up yet? Just found this repo cus I wanted to put my Nvidia Jetson's to the test.. but the support for Docker would be nice.

Not yet! But appreciate you sharing your interest. It has moved up in priority ;)