expelEnclosingWhitespace not working with inner links - Githubissues

ProseMirror / prosemirror-markdown

ProseMirror Markdown integration

https://prosemirror.net

MIT License

344 stars 81 forks source link

expelEnclosingWhitespace not working with inner links #107

Closed ndoherty-xyz closed 1 year ago

ndoherty-xyz commented 1 year ago

Bug

The expelEnclosingWhitespace option is not applied to marks with inner links

Example & Reproduction:

Can easily be replicated on https://prosemirror.net/examples/markdown/ by creating text with the cases below:

italicized text with an inner link and whitespace at the end
bolded text with an inner link and whitespace at the end
italicized text with an inner link and whitespace at the front

Kapture 2023-08-02 at 12 29 01

Issue in the code

Did some digging within the package, and this seems to be related to the changes in this commit
- Specifically because of the added check in the if statement

Happy to help fix this, but I'm new to the internals of Prosemirror and and missing some context around what this added check is accomplishing.

marijnh commented 1 year ago

Thanks for spotting that. Attached patch should help.