search

ProseMirror / prosemirror-markdown

ProseMirror Markdown integration
https://prosemirror.net
MIT License
345 stars 81 forks source link

Escaping underscore breaks link URLs that contain this character #61

Closed enriquecastl closed 2 years ago

enriquecastl commented 2 years ago

Version

1.6.1

What is the problem?

When serializing a document, Prosemirror-markdown breaks links with URLs that that contain underscore characters. The change was introduced in: https://github.com/ProseMirror/prosemirror-markdown/commit/99155977dbfd010d4db5d0d50fe90b08942f01ba

How to reproduce

The following sandbox contains a reproducible script: https://codesandbox.io/s/broken-links-prosemirror-markdown-r9ez0

marijnh commented 2 years ago

Attached patch should fix this.

enriquecastl commented 2 years ago

Thanks for the quick fix @marijnh 🙇🏼