Thanks for all the great work you put into Prosemirror!
We recently used prosemirror-markdown to transform our JSON content to Markdown. While doing that, we had the case that we wanted to render a list in which all items except the first had a delimiter.
This wasn't possible since passing in an empty string as firstDelim was considered falsy in firstDelim || delim.
I would like to propose changing it to firstDelim != null ? firstDelim : delim so that delim really only gets used if firstDelim is null or undefned.
marijnh
commented
2 years ago
Hey!
Thanks for all the great work you put into Prosemirror!
We recently used prosemirror-markdown to transform our JSON content to Markdown. While doing that, we had the case that we wanted to render a list in which all items except the first had a delimiter.
This wasn't possible since passing in an empty string as
firstDelimwas considered falsy infirstDelim || delim.I would like to propose changing it to
firstDelim != null ? firstDelim : delimso that delim really only gets used if firstDelim is null or undefned.