search

ProseMirror / prosemirror

The ProseMirror WYSIWYM editor
http://prosemirror.net/
MIT License
7.67k stars 336 forks source link

Stored Marks/Mark Cursor causes issues with Korean Input on Windows 7 #1014

Open jljorgenson18 opened 4 years ago

jljorgenson18 commented 4 years ago

Issue details

When typing in Korean on Windows 7, the composition is often broken up when stored marks are present. This appears to be due to the mark cursor being selected when the composition starts which then confuses the browser/OS.

Steps to reproduce

  1. Go to the Prosemirror demo
  2. Enable Korean input
  3. Go to an empty line and select "bold" to set a stored mark
  4. Type something in Korean (for example, I just type s-k-a keys over and over)

Expected Result: Composition is inserted as expected. It should look like this 남 남 남

Actual Result: Text is broken up and the first character is not merged to the right block

This pretty much makes typing in Korean unusable.

ProseMirror version

prosemirror-view: 1.13.6

Affected platforms

Windows 7 with latest Chrome. I have not checked on other browsers

Screenshots / Screencast (Optional)

ezgif-4-5f87ab25e02e

jljorgenson18 commented 4 years ago

And the bad part about this issue is that about 22% of Windows users in Korea are still on Windows 7 https://gs.statcounter.com/os-version-market-share/windows/desktop/south-korea

This issue also relates to markCursor issues we have been seeing on Android when storedMarks are present, as shown in the discussion forum here https://discuss.prosemirror.net/t/potential-alternatives-for-cursorwrapper/2264/10