Xenizo aillet/remove blocks performance issue

Proskomma / proskomma-json-tools

Tools for working with Proskomma-derived JSON formats such as PERF and SOFRIA

MIT License

1 stars 2 forks source link

Xenizo aillet/remove blocks performance issue #55

Closed gabrielaillet closed 3 months ago

gabrielaillet commented 3 months ago

Change in SofriaRenderFromProskomma

Remove block In config No more request in for loop No more modification of config field Error when chapters not in document is given

change in Test/code/SofriaRenderFromProskomma

new test to know if error is thrown when given an invalid chapter modification of test to suit new nomenclature modification of test Weird ACT uW milestone (${testGroup}), ask for chapter 25 before 50 with new logique it throw errors thus making the test not pass

mvahowe commented 3 months ago

Added tests for which chapters are returned and for error on bad chapter number. LGTM.