ProspectOne / perfops-cli

A simple command line tool to interact with hundreds of servers around the world.
https://perfops.net/cli
287 stars 45 forks source link

stream results #16

Closed jimaek closed 7 years ago

jimaek commented 7 years ago

If a user does ping --limit 20 then he will have to wait for all 20 results to finish to get any output.

Show results as they come in. And continue showing the loading icon at the end until all tests are finished and results are shown.

jimaek commented 7 years ago
  1. There is a strange movement of the loading icon. It jumps around. Can you fix that?
  2. Can you try using this animation? ⠋⠙⠹⠸⠼⠴⠦⠧⠇⠏
boki commented 7 years ago

I am not sure about 1, though: it does not seem to jump around for me.

jimaek commented 7 years ago

Try running a 20 node test and look at the loading icon. It doesnt stay static but something moves and makes it look jumpy

boki commented 7 years ago

I do/did: but results seem to come in too fast to notice the spinner after the initial wait. And my endless debug spinner with output doesn't show any jumping.

If you mean the vertical movement of the spinner then I do not think there's much to do about that: keeping it above the first output will not work when the output is large enough to cause scrolling. Keeping it static at the top even when scrolling would require keeping track of what's below the spinner, the height of the console, responding to height changes of the console, and probably other things, which seems a bit unfeasible to do.

jimaek commented 7 years ago

Ok, let me test it again as is