I prefer to have a vendor in .gitignore as well but it requires us to change the build scripts and double-check that building of binaries still works. I will try to get more info about how we build and release the binaries from @jimaek to better understand if we can remove vendors from the git.
Yes, I know that it looks weird to add the
vendorto git :) Actually the dependency management tool we use here (go dep) leaves it to a developer to decide what to do withvendor- https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory. And the dev who wrote CLI decided to add it to the git.I prefer to have a
vendorin.gitignoreas well but it requires us to change the build scripts and double-check that building of binaries still works. I will try to get more info about how we build and release the binaries from @jimaek to better understand if we can remove vendors from the git.UPD: @spalax sorry, forgot to mention you