search

Prosper-FRC / robot-main-armstrong

[WORKING] Main code for 9105 robot ARMSTRONG. Code is actively being rewritten on a different repo.
MIT License
0 stars 0 forks source link

Magic Number #4

Open mduffor opened 1 year ago

mduffor commented 1 year ago

https://github.com/FRC5411/9105-armstrong-rewrite/blob/f574bfb10a44d6ecb19dab958a430269858bb1b1/src/main/java/frc/robot/subsystems/ArmSubsystem.java#L49

22.755 is a magic number... should be a named constant (or const class variable) so we know what it is.

mduffor commented 1 year ago

Also this constant should be utilized down in getEncoderVelocity()