Closed jgriss closed 5 years ago
Note: max and sum work on the features (= rows) while the others work on the columns. It might be worth testing whether it's sensible to combine the two.
@veitveit Based on the benchmarks center.median seems to be working best.
To keep the protocol simple, we might also just not add this parameter.
Alternatively, we could add an "advanced parameters" section. What do you think?
In any case, I'm scheduling this for the version after the next one.
voting for keeping things simple
Am Mi., 3. Okt. 2018 um 11:02 Uhr schrieb Johannes Griss < notifications@github.com>:
@veitveit https://github.com/veitveit Based on the benchmarks center.median seems to be working best.
To keep the protocol simple, we might also just not add this parameter.
Alternatively, we could add an "advanced parameters" section. What do you think?
In any case, I'm scheduling this for the version after the next one.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProtProtocols/IsoLabeledProtocol/issues/75#issuecomment-426562861, or mute the thread https://github.com/notifications/unsubscribe-auth/APEZhWCteOgBb9pS9U0c8hRpvALPTaD3ks5uhH0ggaJpZM4W7ZJT .
-- |||/ (o o) ----ooO-(_)-Ooo----
Don't worry about life; you're not going to survive it anyway.
Agreed. Let's not add this parameter.