search

ProteGO-Safe / backend

GNU General Public License v3.0
71 stars 29 forks source link

feat: added initial testing platform #95

Closed galuszkak closed 4 years ago

galuszkak commented 4 years ago

The code is passing CI: https://github.com/galuszkak/backend/actions/runs/188256882

arthurkowalsky commented 4 years ago

Hey @galuszkak

I've changed the base to the release/4.1.2 branch

Please take a look on it and resolve the conflicts :pray:

Thanks!

galuszkak commented 4 years ago

@thecodersio done.

galuszkak commented 4 years ago

@thecodersio test is failing because someone removed that module. I will remove then test too.

galuszkak commented 4 years ago

@thecodersio It looks in this case my PR doesn't add any value add all.

I think it can be then closed. It's over a month hanging and it doesn't make sense now to add this if there is already in this release testing platform. It would make more sense if the development would be more open source and this would be incremental small change. Right now it doesn't add anything substantial.

arthurkowalsky commented 4 years ago

@galuszkak

I agree with you 100% - we can close this PR.

I'm sorry that our development process looks like this. I see a lot of problems related to this here and will bring it up in the next retrospective.