search

Protectator / LoLarchive

A website that keeps track of each of your games in League of Legends
GNU Affero General Public License v3.0
0 stars 1 forks source link

Add Feature? #52

Closed vantzs closed 10 years ago

vantzs commented 10 years ago

Would it be possible to add this tooltip library to the script?

http://tooltip.lolbuilder.net/

it would give us hover tooltips on champs, items, and summoner spells. Also I have update your code and have added some new features to it if you want the URL let me know.

DeathscytheHell NA Summoner Name.

BinaryBrain commented 10 years ago

Also I have update your code and have added some new features to it if you want the URL let me know.

Why don't you make a pull request?

Protectator commented 10 years ago

Hi ! I'm currently working on a version stable enough to make a first "official" release, so I have some work to do on higher priorities tasks for now, but I'll consider adding this after :) Can you post the URL you're talking about ? I play on EUW, summoner name : Protectator

vantzs commented 10 years ago

http://stats.lolfanatix.com

Protectator commented 10 years ago

Ok good, but now... what am I supposed to do with this ?

Protectator commented 10 years ago

Also please take note that this version of the source code of LoLarchive is released under GPL licence, meaning that if you want to make changes and use it on your own it's fine, but if you provide a public access to it (as it is currently, accessible as a public website) and the generated result (the HTML pages) is modified (and in this case, it is), you'll have to actually make your modified source code accessible to public under the same licence too.

vantzs commented 10 years ago

I don't know how to use git or any of that I can zip up the source code I have right now and post a link to it.

Protectator commented 10 years ago

It is perfectly fine if you zip up your source code and put a link on your website to download it ! (where ever you want, in the footer for example, it should just be visible for the users). To be all right, don't forget to include all files including the LICENSE and README, with an exception : DON'T include your ".htpasswd" files in the zip ;)

Protectator commented 10 years ago

If you still have questions, feel free to contact me at kewin.d@websud.ch And about this issue, it is actually a duplicate of #10, so I'll close this one and continue discussion there.