Sortable table - Githubissues

ProteinsWebTeam / interpro7-client

https://www.ebi.ac.uk/interpro/

GNU General Public License v3.0

5 stars 0 forks source link

Sortable table #626

Closed gustavo-salazar closed 3 months ago

gustavo-salazar commented 3 months ago

The main feature added here is sortable buttons for accession in:

Browse by InterPro
Browse by MemberDB
Browse by Set

Changes included to achieve the objective:

Add the isSortable prop to the Table/Column and update the logic to render the headers to split the logic that was already there for isSearchable in Table/Header
Moving some table related css rules into Table/styles.css
Migrating Table/Header into TS.
In loadData/deafults we replace any request with /set/[db]/entry/[db] for /set/[db] which FIX #623 and allows the sorting by to be run in MySQL.

Note 1: This requires an update in the API that is currently in the dev branch. Note 2: First of a series of PRs that are chained to migrate <Table> and all its subcomponents. So when merge, delete the branch to update the next PRs.

coveralls commented 3 months ago

coverage: 21.835% (+0.04%) from 21.8% when pulling 293059ea42d111be3705b4274d992d862f3d28cc on sortable-table into 822af0a9e90c9d98654c3b4b6014583349d0aff2 on dev.

gustavo-salazar commented 3 months ago

Changes requested done

coveralls commented 3 months ago

coverage: 21.565%. remained the same when pulling 6bf03a698a0961c51a843e7702301ce414aa86c1 on sortable-table into 26261fe4b80da4ac31c60fe45771d8e8d0540107 on dev.

coveralls commented 3 months ago

coverage: 21.565%. remained the same when pulling 6bf03a698a0961c51a843e7702301ce414aa86c1 on sortable-table into 26261fe4b80da4ac31c60fe45771d8e8d0540107 on dev.

coveralls commented 3 months ago

coverage: 21.565%. remained the same when pulling 374879b102404eaf115d9bf5592c4fc195c31ada on sortable-table into 26261fe4b80da4ac31c60fe45771d8e8d0540107 on dev.

coveralls commented 3 months ago

coverage: 21.565%. remained the same when pulling 374879b102404eaf115d9bf5592c4fc195c31ada on sortable-table into 26261fe4b80da4ac31c60fe45771d8e8d0540107 on dev.

matthiasblum commented 3 months ago

Looks great, thanks! Feel free to merge.