Ts SimpleTable - Githubissues

ProteinsWebTeam / interpro7-client

https://www.ebi.ac.uk/interpro/

GNU General Public License v3.0

5 stars 0 forks source link

Ts SimpleTable #627

Closed gustavo-salazar closed 4 months ago

gustavo-salazar commented 5 months ago

Migration to typescript and visual framework for the SimpleTable and subcomponents.

Components Migrated:

Table/Body
Table/Row
Table/Column
Table/Views/Table
Table/SimpleTable

SimpleTable is currently only used for KeySpeciesTable as in this page in the live site. So this PR also migrates KeySpeciesTable to ha ve typescript example case for it.

Other changes:

Adding specificity to some EntryMenuLink styles so it doesn't change with some removed foundation imports.
Moving table styles form interpro-new.css into `Table/styles.css.

Note: Second of a series of PRs chained to migrate <Table> and all its subcomponents. Make sure to review #626 first. And, when merging, delete the branch to update the next PRs.

coveralls commented 5 months ago

coverage: 22.079% (+0.2%) from 21.835% when pulling df9585201518c41d887f71f27b619b2e55fe522d on ts-simple-table into 293059ea42d111be3705b4274d992d862f3d28cc on sortable-table.

coveralls commented 4 months ago

coverage: 21.831% (+0.3%) from 21.565% when pulling a02db2f8185d9f5b3a60d4da0840a3ac9d60df98 on ts-simple-table into 6bf03a698a0961c51a843e7702301ce414aa86c1 on sortable-table.

coveralls commented 4 months ago

coverage: 21.831% (+0.3%) from 21.565% when pulling fd18d9e85e2decadf18cea048261f00632603831 on ts-simple-table into 374879b102404eaf115d9bf5592c4fc195c31ada on sortable-table.

coveralls commented 4 months ago

coverage: 21.831% (+0.3%) from 21.565% when pulling b641ab0bd74c3c3eb600baba5343dfd8949dfa21 on ts-simple-table into 374879b102404eaf115d9bf5592c4fc195c31ada on sortable-table.

gustavo-salazar commented 4 months ago

no-decoration should be applied to the link to open the list of proteins https://github.com/ProteinsWebTeam/interpro7-client/blob/a874fc8ecd90ca25e0475611af6f5b0f16ee6569/src/components/Matches/ProteinDownloadRenderer/index.tsx#L33

I did this one!

The button to dowload fasta sequences should be the icon-FASTA

But this one requires changes in multiple files to pass the custom Icon down to the component that actually renders it. will open an issue from it to work on it later.