search

ProteinsWebTeam / interpro7-client

https://www.ebi.ac.uk/interpro/
GNU General Public License v3.0
5 stars 0 forks source link

Fixed matches expanding column #649

Closed apolignano closed 1 month ago

apolignano commented 2 months ago

The column displaying tracks kept expanding for some entries. max-width was required

Closes #637. The example reported was about entry PF11133.

image
coveralls commented 2 months ago

Coverage Status

coverage: 22.791% (-0.1%) from 22.889% when pulling 2c7756ae5931df0cdfe05d6cb8ccae2a9b3faceb on expanding_matches_fix into a81c9333e8c957af8c81b55e032907fe9033ca99 on dev.

apolignano commented 2 months ago

Ok, seems like it gives different results with different screen sizes and hence, window sizes. I had tested it on my laptop, but now it keeps expanding when I open it on my monitor.

It seems that the problem stems from:

https://github.com/ProteinsWebTeam/interpro7-client/blob/bd9f1dc619ef777fd54c5983f8aa28832320a4b8/src/components/ProteinViewer/style.css#L147-L149

Do we want it to be capped at 200px?

gustavo-salazar commented 1 month ago

Mhh I think the cap to 400px was a way to contain the problem. But the real issue was that a previous version of the nightingale track wasn't respecting the initial width parameter. I solved that bug and now width should work.

I'm adding a commit to fix everything to 300px it's fixed so not responsive, but at least doesn't have that weird effect

gustavo-salazar commented 1 month ago

Damn, I pushed that commit to the wrong branch: taxonomy_tree_improvement

gustavo-salazar commented 1 month ago

OK I cherry pick the commit and ist's now here