TS migration of Help components

ProteinsWebTeam / interpro7-client

https://www.ebi.ac.uk/interpro/

GNU General Public License v3.0

5 stars 0 forks source link

TS migration of Help components #651

Closed apolignano closed 3 months ago

apolignano commented 3 months ago

Migrated the remaining JS components under the src/components/Help folder;
Will need more time/guidance for the migration to the Visual framework.

See IBU-11236

coveralls commented 3 months ago

coverage: 22.663% (-0.2%) from 22.889% when pulling 853db03c777d4e20cf4ddc994d4036529b681856 on ts_migration_help_components into a81c9333e8c957af8c81b55e032907fe9033ca99 on dev.

apolignano commented 3 months ago

Tests on GA failed multiple times even if local tests passed. It seems that it was being caused by lint-staged at commit time, splitting the (long) line below the // $FlowFixMe comment (changes were then pushed). Splitting the line manually beforehand and placing the // $FlowFixMe comment above the resulting second sub-line (vs. the first), solved the issue.

apolignano commented 3 months ago

Removed global CSS from Documentation and RTDLink, added local styles;
Added // prettier-ignore comment to avoid lint-staged pre-commit changes to lines below the FlowFixMe comment. Tests passing locally and on GH.
Replaced row and columns classes, using vf-grid now. Vf-stack was causing some layout issues.

apolignano commented 3 months ago

IBU-11236 is specifically about the components under src/components/Help. That is the Help page. I'll look into that.