search

ProteoWizard / pwiz

The ProteoWizard Library is a set of software libraries and tools for rapid development of mass spectrometry and proteomic data analysis software.
http://proteowizard.sourceforge.net/
Apache License 2.0
232 stars 100 forks source link

Reference purl.obolibrary.org for controlled vocabulary URIs #2181

Open mobiusklein opened 2 years ago

mobiusklein commented 2 years ago

To abstract away where a controlled vocabulary, the people at OBOFoundry have asked we reference our controlled vocabulary through http://purl.obolibrary.org/obo/ms.obo. We should also use http://purl.obolibrary.org/obo/uo.obo for the Unit ontology in mzML and mzIdentML.

After searching for the actual struct definition, I noticed the CV instances are from a generated source file that seems to be defined here: https://github.com/ProteoWizard/pwiz/blob/0fdbda9236fd25181464c305549cf75a0ec4fd03/pwiz/data/common/cvgen.cpp#L470-L474

If those URIs are changed do bad things happen?

chambm commented 2 years ago

Probably not. There's a long-standing need to hybridize ProteoWizard's CV architecture so that it can handle newer CVs: i.e. download the newest CV when a CV accession is unknown. The URI will be important when that's implemented (but as long as the purl URL also resolves to the CV it should be ok).