Proteobench / ProteoBench

ProteoBench is an open and collaborative platform for community-curated benchmarks for proteomics data analysis pipelines. Our goal is to allow a continuous, easy, and controlled comparison of proteomics data analysis workflows.
https://proteobench.readthedocs.io
Apache License 2.0
27 stars 7 forks source link

Error when changing `Minimal ion quantifications` #286

Closed vedran-kasalica closed 1 month ago

vedran-kasalica commented 2 months ago

Describe the bug If you scroll the Minimal ion quantifications slider 2 times before the page refreshes the following error occurs:

Screenshot 2024-04-19 at 16 05 51

This was reproduced locally and on the server.

To Reproduce Steps to reproduce the behavior:

  1. Go to DDA Quant Ion Level -BETA-

  2. Click on Additional parameters

  3. Scroll down to Minimal ion quantifications (# samples)

    Screenshot 2024-04-19 at 16 06 09
  4. Slide the slider back and forth (e.g., from 3 to 4 and then back to 3).

  5. The mentioned error should occur

Expected behavior The slider should work without errors.

Desktop (please complete the following information):

RobbinBouwmeester commented 2 months ago

Found it! Problem is located here:

294

Problem is that this function gets a call with empty all datapoints.

wolski commented 2 months ago

Commit 0b4510764fa40f52f741724fab22d3cdeb00f2a3 addresses the error. However, I can see that the figures "Log2 Fold Change distributions by species" and "Coefficient of variation distribution in Groups A and B" are not always updated when the sliders are moved.
The updates work when going from 3 -> 6. However, they are unchanged after moving the slider back to a lower number.

mlocardpaulet commented 1 month ago

Hi! I am not sure that this is related, but I see this error when I use the main locally:

  1. Go to DDA Quant Ion Level -BETA-
  2. upload a MQ evidence file (unknown from ProteoBench)
  3. press parse and bench Returns: no new point in the plot, and n_prec = 0 in the table. When I move the slide Minimal ion quantifications (# samples), the error is corrected.

image image

RobbinBouwmeester commented 1 month ago

Hi! I am not sure that this is related, but I see this error when I use the main locally:

  1. Go to DDA Quant Ion Level -BETA-
  2. upload a MQ evidence file (unknown from ProteoBench)
  3. press parse and bench Returns: no new point in the plot, and n_prec = 0 in the table. When I move the slide Minimal ion quantifications (# samples), the error is corrected.

Number of precursors is 0. That is likely part of the issue.

mlocardpaulet commented 1 month ago

Well, I should have said that the number of precursors in the evidence table is > 30 K. Sorry. 😅

mlocardpaulet commented 1 month ago

Here are the other plots, which are correctly plotted above the main plot:

image
mlocardpaulet commented 1 month ago

Here is a trimmed file that you can use to test if you'd like (Only the top rows of the file that I used to generate the figures) evidence_test_20240508.txt.zip

mlocardpaulet commented 1 month ago

And I just noticed this message, which appears just after plots are loaded. It is located after the description of the intermediate table in the module page, and before the header "Mean error between conditions".

image
RobbinBouwmeester commented 1 month ago

Issue is that for the first submission we do call the part that plots, but not that puts the nr_prec there. I will try to fix this now.

RobbinBouwmeester commented 1 month ago

See #296