Proteobench / ProteoBench

ProteoBench is an open and collaborative platform for community-curated benchmarks for proteomics data analysis pipelines. Our goal is to allow a continuous, easy, and controlled comparison of proteomics data analysis workflows.
https://proteobench.readthedocs.io
Apache License 2.0
27 stars 7 forks source link

:bug: "old_new" data point not set? #288

Closed enryH closed 2 months ago

enryH commented 2 months ago

Describe the bug Upload is not working

To Reproduce DDA_Quant_ion,

Expected behavior Upload either accepted or denied.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context

File "C:\Users\kzl465\Anaconda3\envs\proteobench\lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 535, in _run_script
    exec(code, module.__dict__)
File "C:\Users\kzl465\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 667, in <module>
    StreamlitUI()
File "C:\Users\kzl465\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 56, in __init__
    self._main_page()
File "C:\Users\kzl465\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 157, in _main_page
    self._populate_results()
File "C:\Users\kzl465\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 217, in _populate_results
    self.generate_results("", None, None, False, None)
File "C:\Users\kzl465\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 598, in generate_results
    pr_url = self.make_submission_webinterface(
File "C:\Users\kzl465\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 363, in make_submission_webinterface
    st.session_state[self.variables_dda_quant.all_datapoints]["old_new"] == "new"

Somehow it seems as add_current_data_point is not called anymore.

RobbinBouwmeester commented 2 months ago

Issue was that after uploading a param file, the df resets, still not sure why. Need to fix that in the future.

New copy of the dataframe works: #289

enryH commented 2 months ago

perfect! Thanks.

enryH commented 2 months ago

Hmm. I get a new error now:

INFO:Writing the json to: C:\Users\user\AppData\Local\Temp\tmpyfi6_kwk\results.json                           
Following Github server redirection from /repos/Proteobot/Results_Module2_quant_DDA to /repositories/594        032348                                                                                                          
INFO:Following Github server redirection from /repos/Proteobot/Results_Module2_quant_DDA to /repositorie        s/594032348                                                                                                     
Following Github server redirection from /repos/Proteobot/Results_quant_ion_DDA/branches/master to /repo        s/Proteobot/Results_quant_ion_DDA/branches/main
INFO:Following Github server redirection from /repos/Proteobot/Results_quant_ion_DDA/branches/master to 
DA/branches/master to /repos/Proteobot/Results_quant_ion_DDA/branches/main
2024-04-25 11:04:41.995 Uncaught app exception
Traceback (most recent call last):
  File "C:\Users\user\Anaconda3\envs\proteobench\lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 535, in _run_script
    exec(code, module.__dict__)
  File "C:\Users\user\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 667, in <module> 
    StreamlitUI()
  File "C:\Users\user\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 56, in __init__  
    self._main_page()
  File "C:\Users\user\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 157, in _main_page
    self._populate_results()
  File "C:\Users\user\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 217, in _populate_results
    self.generate_results("", None, None, False, None)
  File "C:\Users\user\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 598, in generate_results
    pr_url = self.make_submission_webinterface(
  File "C:\Users\user\Documents\repos\ProteoBench\webinterface\pages\DDA_Quant_ion.py", line 368, in make_submission_webinterface
    self.ionmodule.write_intermediate_raw(
  File "C:\Users\user\Documents\repos\ProteoBench\proteobench\modules\dda_quant_base\module.py", line 219, in 
write_intermediate_raw
    input_df.to_csv(os.path.join(path_write, "input_df.csv"))
AttributeError: 'NoneType' object has no attribute 'to_csv'

I guess I will need to create a new issue. It's really tricky to debug the submission process...

enryH commented 2 months ago

Create a new issue: https://github.com/Proteobench/ProteoBench/issues/290