Proteobench / ProteoBench

ProteoBench is an open and collaborative platform for community-curated benchmarks for proteomics data analysis pipelines. Our goal is to allow a continuous, easy, and controlled comparison of proteomics data analysis workflows. https://proteobench.cubimed.rub.de/
https://proteobench.readthedocs.io
Apache License 2.0
31 stars 8 forks source link

:bug: Allow local use and UploadFile use in streamlit. Fix #310 #311

Closed enryH closed 4 months ago

enryH commented 4 months ago

Closes #310

mlocardpaulet commented 4 months ago

When I try locally I have the same issue as issue #308 (was corrected by @Julian, works well now when uploading a file on cubimed). It says that the file is too big.

image
enryH commented 4 months ago

It worked for me without any issues.

It's probably the local configuration issue I wrote about before. Modify the webinterface/.streamlit/config.toml the following way. @julianu Did you add a maximum file size item?

[theme]
base = "light"

[server]
enableStaticServing = true
# added: 
enableXsrfProtection = false
enableCORS = false
# julians addition in #308 ?
maxUploadSize = 500

It's a security feature for local execution to increase security.

julianu commented 4 months ago

Yes, I set the maxUploadSizeto 2 GB on the server for now.

What are these two for?

enableXsrfProtection = false
enableCORS = false
mlocardpaulet commented 4 months ago

Thanks Henry, it works very nicely :)

image
mlocardpaulet commented 4 months ago

@enryH should we change the webinterface/.streamlit/config.toml file in the repo?

enryH commented 4 months ago

@enryH should we change the webinterface/.streamlit/config.toml file in the repo?

This is a question for @julianu . I think we should rather document it as it's a security feature for local execution which should not be deactivate when published. So it will depend on how the server is configured now.

enryH commented 4 months ago

Yes, I set the maxUploadSizeto 2 GB on the server for now.

What are these two for?

enableXsrfProtection = false
enableCORS = false

If I do not set it, my browser does not allow to load files from the local disk. It's probably a security feature.