Circuit item description unreadable on screens with rounded corners

[Piotrassin]

Hello, I am using a Samsung Galaxy S9 which has rounder corners and it interferes with the data displayed I the top left corner upon clicking on any circuit item. Steps to reproduce.

1. Start a new circuit or load an example
2. Go to settings panel and make sure to have "show details" enabled in the settings. In polish translation it's labeled "Pokaż opis" and I can't change the app language so I am guessing the English name.
3. Tap on any item on the circuit
4. The first two lines of the details is interfering with the rounder corner. The first line is sometimes unreadable as the text is off screen.
5. Visualisation picture below. I modified the screenshot to visualize the problem as the screen in rounded, but the screenshot is not and normal screenshot shows the details properly.

[Proto-App]

Hello @Piotrassin Thank you for very detailed description. We will check possible solutions, but we are not sure that there is any Android API to check if device has rounded corners.

[Piotrassin]

Thanks! Possibly a slight margin from the screen left and top borders will fix the problem? It's not that elegant, but it should work :D

[Proto-App]

Indeed it should work but we don't want to apply small margin on every device with regular corners. At least we will add your device and handle it differently.

[ricKapali]

...having the same issue w/Samsung Galaxy Fold 4. Any chance of adding the Fold 4 to the "exception list"? Thx in advance!

[Proto-App]

Hello @ricKapali Yes, it is hard to believe that Android does not provide any API to get corner size 😐

[Piotrassin]

Indeed it should work but we don't want to apply small margin on every device with regular corners. At least we will add your device and handle it differently.

I agree. Every device is different and may have a different corner radius hence making an exception with different margin rules for each one is rather cumbersome, but why not add a static margin just as you mentioned? The text is small enough that adding a margin wouldn't obstruct the view, but if the margin was large enough it would solve the issue for almost all of the devices.

[Proto-App]

@Piotrassin @ricKapali Could you share model number from phone settings?

[ricKapali]

Absolutely...thank you(!) in advance, Rich.

SM-F936U1

On Fri, Nov 3, 2023, 12:12 PM PROTO Team @.***> wrote:

@Piotrassin https://github.com/Piotrassin @ricKapali https://github.com/ricKapali Could you share model number from phone settings? [image: samsung-galaxy-find-imei-serial-number-model-number-phone-imei-serial-model-number-displayed] https://user-images.githubusercontent.com/63373346/280342911-a0fee9df-729a-4968-b083-12d449a15f78.jpg

— Reply to this email directly, view it on GitHub https://github.com/Proto-App/Proto-Android/issues/223#issuecomment-1792727715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI57KKUXW6MDFAXNAXHEY2TYCUJYDAVCNFSM6AAAAAAW7POVFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSG4ZDONZRGU . You are receiving this because you were mentioned.Message ID: @.***>

[Proto-App]

@ricKapali @Piotrassin Implemented in version 1.25.0