search

ProtoDef-io / node-protodef-validator

Validate ProtoDef protocol definition in node
1 stars 3 forks source link

Update ProtoDef submodule #11

Closed extremeheat closed 9 months ago

extremeheat commented 9 months ago

Failing because https://github.com/ProtoDef-io/ProtoDef/compare/4e2d2d1c16827ba61da5ff8abbb42cc1d353210a...674aa4752d5d0ffcb04b1b030a262a4be263680d#diff-74b870a7a0657a0b5e81baa41994a5ce593ecb87b6831bd26f3f5e84426c896c

Seems the change to strings, specifically cstring, is breaking it

rom1504 commented 9 months ago

The error seems to be about numeric?

extremeheat commented 9 months ago

Yeah, the error does say something about varints but I don't think that's the cause of it. Undoing the change in nickelpro's commit fixes the test, so after some debugging it seems cstring schema declaration is what's causing it to break