Fix option sizeof and write

[rom1504]

Do you think it's possible to add a regression test for this there https://github.com/ProtoDef-io/ProtoDef/blob/master/test/conditional.json ?

[rom1504]

I think we should probably be iso to https://github.com/ProtoDef-io/node-protodef/blob/master/src/datatypes/conditional.js#L47 here. (Even if this behavior is a bit weird, relying on js implicit casting for null and undefined)

[Karang]

Do you think it's possible to add a regression test for this there https://github.com/ProtoDef-io/ProtoDef/blob/master/test/conditional.json ?

Yes the case that was not tested was the "option not present" one. So basically an undefined value and a buffer containing only a byte at 0.

Can we do something like:

{
   "value": undefined,
   "buffer":["0x00"]
}

?

[rom1504]

Could you add that ?

[rom1504]

Maybe, I'm not sure, try it

[Karang]

Maybe, I'm not sure, try it

it works with null but we cannot test undefined