ProtoThis / python-synology

MIT License
55 stars 38 forks source link

requirements.txt is missing in SDIST source on Pypi, can't compile. #66

Open onkelbeh opened 4 years ago

onkelbeh commented 4 years ago

Hi,

I hope you don't mind that I use your integration in Gentoo Overlay for Home Assistant. You will find the corresponding Ebuild files in https://github.com/onkelbeh/HomeAssistantRepository/tree/master/dev-python/python-synology.

Normally I would use the release file from Pypi in SDIST format, which you already provide, because this is technically the best source for Gentoo Python Ebuilds, it is able to use Gentoo's mirror system.

Unfortunately these file is broken in all tested releases (0.7.0 - 0.8.2): requirements.txt is missing in the archives, so setup.py fails.

I now use the archives from github.com. These compile without errors.

Thanks a lot.

Quentame commented 4 years ago

Hi !

I don't mind this library is ment to be used on multiple projects of course ! already used in Home Assistant actually : https://github.com/home-assistant/core/tree/dev/homeassistant/components/synology_dsm

Unfortunately I don't know why this file is broken, I don't know enought about build with setup.py at the time.

Can you try to fix the build ? Provides working libraries as an exemple ?

I'll be happy to review your PR.

Thanks.

onkelbeh commented 4 years ago

Hi,

yes, that's what the repo is for: Home Assistant on Gentoo Linux.

Unfortunately I don't know anything about GitHub skripting. I could look at some other integrations and what they did to fix this (you are not alone) :-) No need to hurry, as long as your release tags at GitHub work fine. As soon as I stumble upon a good release script, I'll let you know.

Greetings \B.

digi100 commented 3 years ago

When do you plan to fix this issue? I am not able to use your library? Or is there a workarround?

onkelbeh commented 3 years ago

My current workaroud is to use the source from Github, it compiles fine.

digi100 commented 3 years ago

Could you please provide me a hint how to complile it localy, Which commands do I have to use?