search

Protobuild / Protobuild

This project has been retired.
MIT License
150 stars 33 forks source link

TargetFrameworkVersion for Xamarin.Android #187

Open takeshich opened 7 years ago

takeshich commented 7 years ago

Hi there,

I proposed a fix for AndroidSupportedAbis(https://github.com/Protobuild/Protobuild/issues/185), but the 64bit ABIs(arm64-v8a,x86_64) require Android 5.0 and later.

Looking at the GenerateProject.CSharp.xslt,TargetFrameworkVersion is v4.2. https://github.com/Protobuild/Protobuild/blob/3a6603586fe17efde5c9e686eb02abbfe882a652/Protobuild.Internal/BuildResources/GenerateProject.CSharp.xslt#L115

I did not notice because I specified the TargetFrameworkVersion in the definition file. 🙏

I think it would be better to change to v5.0 and later, however in the case of specifying the older version(e.g. v4.2), it is necessary to customize to remove the 64bit ABIs from <AndroidSupportedAbis> it using GenerateProject.CSharp.xslt.

Thanks ✋

hach-que commented 7 years ago

Do you know if changing TargetFrameworkVersion to a higher value impacts the devices the app can target?

takeshich commented 7 years ago

I'm sorry. I do not know in detail.

I saw this page. https://developer.xamarin.com/guides/android/application_fundamentals/understanding_android_api_levels/

Target Framework – Specifies which framework to use in building your application. This API level is used at compile time by Xamarin.Android.

I think that the minSdkVersion and targetSdkVersion are specified that the app can target, in the AndroidManifest.xml.