search

ProtocolSupport / ProtocolSupportBungee

ProtocolSupport addon for bungee
GNU Affero General Public License v3.0
31 stars 29 forks source link

Breaks hybrid servers #70

Closed Artuto closed 5 years ago

Artuto commented 5 years ago

As you might now, many servers use a "hybrid" auth system, where Premium users keep their Mojang UUID but Cracked users can still join and play normally. Well, a user in my server reported that they couldn't connect with a Cracked account. I've tested it and discovered PSB caused it.

Could this be patched please?

Also, i'd like to request a way to disable Authentication for PE users, maybe a boolean in a config file.

Shevchik commented 5 years ago

Well, this is not a normal bungee behaviour, so you are using some sort of plugin to achieve that. I need to know which plugin is that. The pe auth follows the global bungee online mode config.

Artuto commented 5 years ago

I'm using Bungee Premium Authenticator

Artuto commented 5 years ago

[Proposal] I could open a PR and make it toggle-able by using a start flag.

Shevchik commented 5 years ago

The provided pluguin has no available source so i can't help you.

Artuto commented 5 years ago

I was able to fix this issue by reverting https://github.com/ProtocolSupport/ProtocolSupportBungee/commit/d07abb58b6375179a86914cdf994fd6889834bf6

Shevchik commented 5 years ago

By reverting rhis patch you made bungee always work in offline mode. Because this patch was fixing it.

Artuto commented 5 years ago

I doubt it because if I turned off online-mode in config.yml users werent authenticated at all. However, reverting it allows that plugin to work. If you want I can give you a copy to test

Shevchik commented 5 years ago

Try without that plugin and see the result. Before that patch no matter what online-mode setting was, bungee was working in offline mode. It was still following the online mode option set via bungee login event tho. Now it follows the setting, and event is only handled after that.

Artuto commented 5 years ago

Without the plugin makes the server completely offline or online mode, which I dont want.

With that plugin Premium users get their UUID restored. Without it we would need to choose either making it premium only (which is not an option because at least half of my user-base is cracked) or having offline UUIDs which is also bad.

The plugin just pretty much let Cracked users to join and set a password.