search

ProtocolSupport / ProtocolSupportPocketIssues

Issue-tracker for ProtocolSupport pocket edition.
6 stars 0 forks source link

Spawn egg items are incorrectly mapped #33

Closed magicus closed 5 years ago

magicus commented 5 years ago

Spawn eggs items are incorrectly mapped. They show up as "generic" white (!) spawn eggs when e.g. stored in a chest, and they all just spawn pigs.

magicus commented 5 years ago

Argh, it's just all messed up. :-( For instance, we currently have zombie spawn eggs as pedata 54, but that will spawn a horse. And spiders have pedata 52, but that will spawn a vex.

I have looked around the web for a proper list of spawn egg ids on PE (the IDs we have are from java edition, and they clearly do not match up), but found nothing. Back to the good ol´ trial and terror, I believe..

magicus commented 5 years ago

Actually, we can have PSPE tell us the proper value of any item! Just add logging in ItemStackRemapper.remapFromClient(), and you will find out the correct ID/data from any item you're dealing with. I hijacked PEItems.getModernIdByPEIdData() to get a good comparison to what we thought we knew...

magicus commented 5 years ago

This way I have figured out, and verified, that cow is 11 and chicken is 10.

7kasper commented 5 years ago

You fixed it (I think) 😄

colinrgodsey commented 5 years ago

1.8 broke this again. Eggs dont have the legacy durability anymore, they have an NBT tag with the entity name.

7kasper commented 5 years ago

Thats better bc thats how pc works too i think

magicus commented 5 years ago

Also, all spawn eggs are black. But maybe that is just a result of the change to NBT tags..?

magicus commented 5 years ago

Actually, spawn eggs work just fine in 1.9. But they look black. I'll open a separate bug for that.