search

ProtocolSupport / ProtocolSupportResourcesGenerator

Generate resources (mostly remapping tables) needed to build ProtocolSupport
GNU Affero General Public License v3.0
3 stars 3 forks source link

Mapping of smooth_stone_slab to stone_slab (avoiding cobblestone replacements) #3

Open zeronerve opened 4 years ago

zeronerve commented 4 years ago

Scenario: Any blocks that were placed using older clients as stone_slab (id 44) in older servers (less than 1.12 I think) are being converted to smooth_stone_slab when the worlds are imported into newer servers. This creates a scenario where---because there's no "smooth_stone_slab" in early clients---Protocol Support renders the stone_slab (44) as a cobblestone_slab (44:3), which for us, has disrupted the feel of several maps which rely on smooth_stone_slab. Is it possible that you modify Protocol Support so that older clients interpret any smooth_stone_slab as stone_slab instead of cobblestone_slab, so they'll appear correctly for players using older clients.

This could also correct issue ProtocolSupport/ProtocolSupport#1176

zeronerve commented 4 years ago

slab-issue

Shevchik commented 4 years ago

You can configure the mapping yourself using a plugin that uses protocolsupport api, such as protocolsupportstuff. Changing default mappings is always a low priority task for us, so unless somebody PRs changes to ProtocolSupportResourcesGenerator, this change won't be done.

zeronerve commented 4 years ago

Thanks for the quick reply!

zeronerve commented 4 years ago

I added this to the ProtocolSupportStuff config and everything looks great, thanks!. ....

blocks:
- from-state: minecraft:smooth_stone_slab[type=top]
  to-state: minecraft:stone_slab[type=top]
  before: MINECRAFT_1_12_2
- from-state: minecraft:smooth_stone_slab[type=bottom]
  to-state: minecraft:stone_slab[type=bottom]
  before: MINECRAFT_1_12_2
- from-state: minecraft:smooth_stone_slab[type=double]
  to-state: minecraft:stone_slab[type=double]
  before: MINECRAFT_1_12_2

No more cobblestone slabs.