Savefile: PC version doesn't handle endianess

Protofall / Crayon-Savefile

A savefile system designed to take up little space and support version control. Works on PC and Dreamcast

BSD 3-Clause "New" or "Revised" License

3 stars 0 forks source link

Savefile: PC version doesn't handle endianess #1

Open Protofall opened 4 years ago

Protofall commented 4 years ago

This needs to be a requirement before the PC port of Crayon happens.

Protofall commented 4 years ago

Endianess must be considered for

crayon_savefile_serialise()
crayon_savefile_deserialise()
crayon_savefile_check_savedata() When we check the version
And possibly more places (Such as the save_savedata function)

Protofall commented 4 years ago

I also need a better understanding of how endian-ness works. What happens if our buffer isn't a multiple of 4 bytes long (ie, 23 bytes long, how do we handle the last 3 bytes). The answer might be to extend to the nearest multiple of 4 bytes, but I'm not sure.

Protofall commented 4 years ago

Some useful info on byte order with endian-ness

https://commandcenter.blogspot.com/2012/04/byte-order-fallacy.html