search

ProtonLights / proton-runner

Show runner for Proton
MIT License
0 stars 1 forks source link

Working code for 2016 show #7

Closed bookdude13 closed 7 years ago

bookdude13 commented 7 years ago

Pretty much the whole implementation of the runner in this pull request. I can break it up into a few smaller ones if desired. Mostly trying to get back to master, since I did a poor job syncing my branch with master during development.

bookdude13 commented 7 years ago

Bump

bookdude13 commented 7 years ago

Is that the binary you used? Did you have a problem running?

computergeek125 commented 7 years ago

I found a binary in the repo. You're not supposed to have binaries in a repo, since each system will built its own. Normally binaries land in an ./out/ or ./bin/ directory that can be added to .gitignore

bookdude13 commented 7 years ago

Ok, will move into an ignored ./bin directory. This can also be tweaked in PR #8 by providing the path to the proton_cli binary instead of copying it.

bookdude13 commented 7 years ago

Got interesting "library not found" errors when running from the .bin directory. Ended up running cargo install on proton-cli, adding $HOME/.cargo/bin to my path, then assumed that the proton-cli binary could be found. This is cleaner anyway.