Fix #101 - support for mailto links

ProtonMail / WebClients

Monorepo hosting the proton web clients

GNU General Public License v3.0

4.37k stars 556 forks source link

Fix #101 - support for mailto links #113

Closed ArcanisCz closed 5 years ago

ArcanisCz commented 5 years ago

Hi! Added support for mailto links from #101. Three weak points though:

only basic mailto support. With extended support, i ran into url escaping issues. At that point, it would be best to add separate route for that, with its own query params to not mix with conversation query params. And that would be quite big addition in app (With extended support, i mean /inbox?mailtoUrl=mailto:name1@rapidtables.com%3Fcc%3Dname2@rapidtables.com&bcc=name3@rapidtables.com&subject=The%20subject%20of%20the%20email&body=The%20body%20of%20the%20email)
mailtoUrl is scattered in multiple places, since it has to be retained through login. Also, it would be best if the name is some constant.
No tests added and no tests ran, because your stack is heavily dependant on unix based systems, and i have windows. As for yet, i have no quick solution for running tests on my pc.

Hope it helps! Arcanis

ArcanisCz commented 5 years ago

Any news about this PR after few months? Are you interested or should i close it?

dhoko commented 5 years ago

Any news about this PR after few months? Are you interested or should i close it?

Hey 👋 sorry for the delay :/ We've talked about it and that's a good idea but it would be better if we were able to only load the composer instead of the whole app. ex: Something similar to an encrypted email sent to a non protonmail account.

As it's done today it would be difficult to do, we need to load the whole app :/ We added this feature inside the pipe, it should come later.

ArcanisCz commented 5 years ago

Ok, no problem, only tried to fix issue #101

Maybe you could consider to share your issue to work on, if you deem project as opensource? This way (and given protonmail's response times), its hard to contribute....

stephanlachnit commented 5 years ago

We added this feature inside the pipe, it should come later.

Are you still working on this?

dhoko commented 5 years ago

Yes, but it's not high priority. We need to make changes inside the webapp before, because having to load the full webclient is a bit too much.

stephanlachnit commented 5 years ago

I don't know about the technical details, but would it be possible to simply save the mailto link locally one the users machine, and parse it to the webapp once the user is logged in?

I think ProtonMail is great for everyone who cares about FOSS, but a lot of FOSS development is done with mail and the mailto protocol helps to easily reply to messages. For example take the Debian BTS: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923851

You can reply with one click to messages thanks to the mailto links. On firefox it is pretty simple to write extensions which add mailto support for websites. I already created one for ProtonMail: https://github.com/stephanlachnit/mailto_protonmail (which obviously doesn't work yet)