search

ProtonMail / WebClients

Monorepo hosting the proton web clients
GNU General Public License v3.0
4.5k stars 568 forks source link

Renaming labels breaks filters #140

Closed dmtucker closed 5 years ago

dmtucker commented 5 years ago

Describe the bug Renaming a Label causes Filters to stop applying it.

To Reproduce Steps to reproduce the behavior:

  1. Create a Label, A.
  2. Create a Filter that applies Label A.
  3. Rename the Label to B.
  4. See that the Filter no longer applies any Labels.

Expected behavior Filters are unaffected by changes to Labels.

Desktop (please complete the following information):

bartbutler commented 5 years ago

Going to mark this as WONTFIX--reparsing potentially large numbers of filters every time someone makes a label name change is not feasible, and the filters use Sieve as the underlying filtering language which uses label names, so it's not possible to use an invariant label identifier there.