Not sure if bug or feature request, hence reporting as the latter.
Is your feature request related to a problem? Please describe.
Pressing the escape key while the pop-up dialog for an external link in an email is visible, currently closes not only the pop-up dialog but also the email. This happens both in the full-page (row) email layout and the vertical-split (column) layout.
This compounds with the related issue that pressing enter in the pop-up dialog opens the external link, but does not close the dialog. I regularly get emails (think notification emails) where I want to open a link in the email, do stuff on the webpage, close the page, and then delete the email. Avoiding the mouse, I open the email (in full-page layout), click the link somehow, and press enter. When I come back to the protonmail tab later, I press escape to close the dialog which is still open because of said related issue, and press t to trash the email — which works, I think, but closes the email first and then trashes it in the inbox view. This always scares me because I have no proof whatsoever that I deleted the right email, making me undo and try again explicitly.
[related: thanks heaps for 'undo'.]
I'm probably reflexively doing some actions no-one else does regularly, but I do think some usability improvements are possible here.
Describe the solution you'd like
Pressing escape in the external link pop-up dialog should only close the dialog, not the email as well.
Alternatively, or additionally:
Pressing enter in the external link pop-up dialog should open the link and close the dialog.
Describe alternatives you've considered
Trashing with t not working in the inbox view without first explicitly selecting the email (e.g. using x). This would make the interface feel safer to me (the highlight border on the left is fairly arbitrarily placed sometimes, and also a minor UI element, while selecting an email using the checkbox or x feels like the right amount of ceremony to justify deleting an email using one keypress). However, this would be a breaking change that has a far higher probability of breaking people's workflows, I think, than the alternatives I described above.
Not sure if bug or feature request, hence reporting as the latter.
Is your feature request related to a problem? Please describe. Pressing the
escapekey while the pop-up dialog for an external link in an email is visible, currently closes not only the pop-up dialog but also the email. This happens both in the full-page (row) email layout and the vertical-split (column) layout. This compounds with the related issue that pressingenterin the pop-up dialog opens the external link, but does not close the dialog. I regularly get emails (think notification emails) where I want to open a link in the email, do stuff on the webpage, close the page, and then delete the email. Avoiding the mouse, I open the email (in full-page layout), click the link somehow, and pressenter. When I come back to the protonmail tab later, I pressescapeto close the dialog which is still open because of said related issue, and presstto trash the email — which works, I think, but closes the email first and then trashes it in the inbox view. This always scares me because I have no proof whatsoever that I deleted the right email, making me undo and try again explicitly.[related: thanks heaps for 'undo'.]
I'm probably reflexively doing some actions no-one else does regularly, but I do think some usability improvements are possible here.
Describe the solution you'd like
escapein the external link pop-up dialog should only close the dialog, not the email as well.Alternatively, or additionally:
enterin the external link pop-up dialog should open the link and close the dialog.Describe alternatives you've considered Trashing with
tnot working in the inbox view without first explicitly selecting the email (e.g. usingx). This would make the interface feel safer to me (the highlight border on the left is fairly arbitrarily placed sometimes, and also a minor UI element, while selecting an email using the checkbox orxfeels like the right amount of ceremony to justify deleting an email using one keypress). However, this would be a breaking change that has a far higher probability of breaking people's workflows, I think, than the alternatives I described above.Additional context (none)