search

ProtonMail / WebClients

Monorepo hosting the proton web clients
GNU General Public License v3.0
4.53k stars 571 forks source link

[v4 Beta / Android] Sender's name incorrectly displayed based off of From: header contents #239

Closed charukiewicz closed 3 years ago

charukiewicz commented 3 years ago

Describe the bug

The Beta version of the web client and the Android client do not correctly display the sender's name correctly in certain situations and will instead truncate the contents of the From: header.

To Reproduce

Steps to reproduce the behavior:

  1. Receive an email that matches the characteristics in the examples below
    • The types of emails that cause an issue seem to be From: Someone via Mailing-List <mailing-list@example.org>
  2. View the email

Expected behavior

The entire name of the sender should be displayed.

Screenshots

Here are some headers from an email with the issue:

From: YueCompl via Haskell-Cafe <haskell-cafe@haskell.org>
Reply-To: YueCompl <removed-for-privacy>
Content-Type: text/html

(CORRECT BEHAVIOR) Here's how the email renders in the old v3 web client: protonmail-v3-client-from-header

(INCORRECT BEHAVIOR) Here's how the email renders in the new v4 web client: protonmail-v4-client-from-header

(INCORRECT BEHAVIOR) Here's how the email renders on the Android inbox view: protonmail-android-client

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

As mentioned above, this isn't an issue in the old web client, so the behavior should just be changed to mirror that.