search

ProtonMail / WebClients

Monorepo hosting the proton web clients
GNU General Public License v3.0
4.27k stars 545 forks source link

Make attachments downloads always have a generic mime type #268

Closed Prinzhorn closed 2 years ago

Prinzhorn commented 2 years ago

This is in response to my support ticket 1005204

In Firefox PDF attachments won't download for me, they will navigate to the literal blob: URL and away from the ProtonMail client (both on mail. and old.). Blobs used for downloads should not have a specific mime type the same way server responses shouldn't if they need to trigger a download.

I haven't tested this, all I did was some ctrl+f on the source and I assume this is the right fix. It's what I was assuming to be the root cause in the first place. Do with it whatever you want.

Prinzhorn commented 2 years ago

Might be a bug in https://github.com/eligrey/FileSaver.js though. You'll figure it out :+1:

Prinzhorn commented 2 years ago

https://support.mozilla.org/en-US/kb/manage-downloads-preferences-using-downloads-menu