When will Dark Mode for email body will be released?

ProtonMail / WebClients

Monorepo hosting the proton web clients

GNU General Public License v3.0

4.27k stars 545 forks source link

When will Dark Mode for email body will be released? #272

Open romeoacevedo opened 2 years ago

romeoacevedo commented 2 years ago

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

[ ] I have searched open and closed issues for duplicates
[ ] This isn't a feature request
[ ] This is not a report about my app not working as expected

vladimiry commented 2 years ago

If I got it right, it's currently hidden under the feature flag/code (the list gets requested by core/v4/features API call): https://github.com/ProtonMail/WebClients/blob/fd6d7f6479dd2ab0c3318e2680d677b9e61189cd/applications/mail/src/app/components/message/hooks/useMessageDarkStyles.ts#L15

romeoacevedo commented 2 years ago

Can you use that in your app? @vladimiry

vladimiry commented 2 years ago

@romeoacevedo it's hidden under the feature flag/code for a reason, so I consider the feature incomplete. Not going to test it at the current stage or until it's named complete here by the proton team. I can consider Dark Reader integration in the app, but only when/if this/proton-built-in feature gets canceled.

romeoacevedo commented 2 years ago

@vladimiry Do you have a timeframe in mind in which you might consider doing Dark Reader even if ProtonMail hasn't officially canceled the feature? Some apps get features indefinitely postponed. It could be years until they decide that they are officially canceling the feature.

vladimiry commented 2 years ago

@romeoacevedo I don't normally provide a timeframe for the non-commercial/open-source contribution. So the answer is no. Besides, discussing such matter in this repository is an off top.