ProtonMail / WebClients

Monorepo hosting the proton web clients
GNU General Public License v3.0
4.52k stars 570 forks source link

fix(pass): fix KeePass import of legacy TOPT definition #336

Closed nagromc closed 1 year ago

nagromc commented 1 year ago

According to the KeePassXC source code, there are at least two TOTP definition formats:

This fixes the import of TOTP definitions using the legacy format.

nagromc commented 1 year ago

For reference, the bug has been reported on Reddit in May: https://www.reddit.com/r/ProtonPass/comments/13oqruk/comment/jl79ld1

D-Bao commented 1 year ago

Merged in https://github.com/ProtonMail/WebClients/commit/16a64e662109348c6df0254ed09a0a0d4cd5094f. This will be very useful for users who stored their TOTP in a legacy KeePassXC version, thanks a lot for your contribution!