Why some webpage's favicon don't appear in proton Pass?

ProtonMail / WebClients

Monorepo hosting the proton web clients

GNU General Public License v3.0

4.53k stars 571 forks source link

Why some webpage's favicon don't appear in proton Pass? #408

Open thepragmaticmero opened 2 months ago

thepragmaticmero commented 2 months ago

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

[x] I have searched open and closed issues for duplicates
[x] This isn't a feature request
[x] This is not a report about my app not working as expected

I tried to file a report, but I have no idea where the "contact" button is. So I'm doing it here.

Why some webpages, like xdaforums.com or crypt.ee don't appear with favicons inside proton pass? Screenshot From 2024-09-20 09-08-58 w h y ? my OCD hates it! >n<

thepragmaticmero commented 2 months ago

reddit moderators coming to say "reports don't go here 🤓☝️" please abstain.

AtmosphericIgnition commented 2 months ago

For me, these are just some of the sites that have browser favicons, but no favicons in ProtonPass:

bethesda.net bugzilla.mozilla.org cttstore.com ea.com epicgames.com etesync.com liberapay.com pidlitacka.cz polycentric.io community.signalusers.org spotternetwork.org verizon.com vudu.com

Almost 1/2 of my Proton Pass entries have no favicons, which makes it a little hard to find sites quickly.

ppo-38 commented 1 week ago

And it seems that if an item item contains several websites, only the first website in list is used to display the favicon. For some items, I have to change website order to have a favicon. It could be very nice to fix this UI issue to improve user experience.