ProtonMail / WebClients

Monorepo hosting the proton web clients
GNU General Public License v3.0
4.5k stars 568 forks source link

Conversation greyed out even when containing a new email. #96

Closed JulienPalard closed 6 years ago

JulienPalard commented 6 years ago

This is the counterpart of #79 :

I'm having a folder, github, which was marked with a (1) but by clicking on it to open this folder, all conversations (only 5 conversations) were displayed "grey" (meaning: no new mail in the converation) not "black and white" (meaning : there's an unread email in this thread).

I had to click on all conversations to see which one (the last one obviously, the one on the top, but I started from the bottom) to see which one contained a new message. I was more seraching for a way to drop the (1) than to find an unread messages, as I though I faced issue #79 at first.

Desktop (please complete the following information):

bartbutler commented 6 years ago

So in this case the (1) was correct but the conversation highlighting was off?

JulienPalard commented 6 years ago

Yes the (1) was right as far as I can tell [1], but the conversation was not highlited properly, it was grey like a conversation with no unread messages.

[1]: My brain first expected #79 when I spotted it so there's a little chance I got confused. Very little but existing, I should video-capture everything þ

JulienPalard commented 6 years ago

Got the bug today again, with a screenshot this time: bug-protonmail

Here's the (1) near github is right, I'm having one unread email in the OsmAnd is slow on Android O conversation.

While opening this conversation, the (1) next to github dissapeared while the last mail (the unread one) showed-up.

bartbutler commented 6 years ago

Ignoring the sidebar count for a moment, was the unread message in the github folder or in inbox? I ask because conversations can include messages from different folders, whereas the sidebar just counts unread for that folder/label, i.e., they are context dependent. So you could have a conversation with an unread message in inbox, all messages in 'github' read, and it would show up as grey (no unread messages) in the github folder listing.

JulienPalard commented 6 years ago

The unread message was the last one of a "thread" of emails in the github folder.

So you could have a conversation with an unread message in inbox, all messages in 'github' read, and it would show up as grey (no unread messages) in the github folder listing.

I don't think it's my case as my github folder is a part of my sieve filter:

[...]
elsif header :contains "list-id" ".github.com>" {
    fileinto "github";
}
[...]

Yes, I ocasionally move emails from my github folder to my inbox (a way for me to "mark them as TODO" / to make them more visible when I have something to do with them), but I don't mark them as unread when I do, and I had nothing "todo" with this email, so it can't be the case.

bartbutler commented 6 years ago

OK, just wanted to make sure.

JulienPalard commented 6 years ago

Spotted it again today with a specific configuration:

I do not exclude that all previous cases were similar (whole conversation in trash except a single unread email in folder).

EpokK commented 6 years ago

This report seems a duplicate from: https://github.com/ProtonMail/WebClient/issues/79

About this report: https://github.com/ProtonMail/WebClient/issues/96#issuecomment-413495574

@JulienPalard Unread counter is specific per folder. So if you have a thread in Trash and one of the message is unread and is in github folder, unread counter equals 0 for this conversation.

If you go to github folder and check this conversation, then it will be marked as unread.

JulienPalard commented 6 years ago

Hi @EpokK, I do not understand the wontfix label, my experience is:

Can this really be considered a feature? From my user experience, it's clearly a problem.

see: