add AddUserId , support UserAttribute,

ProtonMail / go-crypto

Fork of go/x/crypto, providing an up-to-date OpenPGP implementation

https://pkg.go.dev/github.com/ProtonMail/go-crypto

BSD 3-Clause "New" or "Revised" License

330 stars 100 forks source link

add AddUserId , support UserAttribute, #123

Closed izouxv closed 2 years ago

izouxv commented 2 years ago

create a AddUserId function in Entity struct

izouxv commented 2 years ago

Hi I add a addUserId api, and support userAttrbute veriable in Entitly, it will support photo in the keys, and compatible with openpgp 2.3.6

please take some time merging thank you.

twiss commented 2 years ago

Hi :wave: Thanks for the PR! However, the PR seems to be doing 3 quite separate things (adding user IDs, support for user attributes, and compatibility with GnuPG 2.3). Could you make separate PRs for each, please? And also, could you elaborate on what the issue with GnuPG 2.3 is, and what the workaround does? Has the issue been reported in GnuPG? Etc.

izouxv commented 2 years ago

done

twiss commented 2 years ago

Closing in favor of #125 and #126.