search

ProtonMail / go-crypto

Fork of go/x/crypto, providing an up-to-date OpenPGP implementation
https://pkg.go.dev/github.com/ProtonMail/go-crypto
BSD 3-Clause "New" or "Revised" License
334 stars 101 forks source link

Add support for user attributes in Entity #124

Open izouxv opened 2 years ago

izouxv commented 2 years ago

HI

Can you enable UserAttribute feature in Entity This will read and set the avatar

thank you

izouxv commented 2 years ago

i did it

twiss commented 2 years ago

Hi :wave: FWIW, it's fine to keep the issue open until the PR is merged, if you want.

izouxv commented 2 years ago

done

dpifke commented 2 months ago

I was looking into this functionality today, and it appears https://github.com/ProtonMail/go-crypto/pull/133 (split from previous PRs) is still pending. Is this just waiting on code review, or is there more work to do here? Happy to help if I can!

izouxv commented 2 months ago

this waiting on code review

izouxv commented 2 months ago

it rebase on main branch current. please check the pr, thank you

izouxv commented 1 month ago

@twiss @dpifke hi can you check the pr, thank you

twiss commented 1 month ago

Apologies for the long delay in reviewing, done now. It was a large one 😅