search

ProtonMail / go-crypto

Fork of go/x/crypto, providing an up-to-date OpenPGP implementation
https://pkg.go.dev/github.com/ProtonMail/go-crypto
BSD 3-Clause "New" or "Revised" License
334 stars 101 forks source link

add photo api #133

Open izouxv opened 2 years ago

izouxv commented 2 years ago

add photo api

izouxv commented 2 years ago

@twiss

izouxv commented 1 year ago

@twiss can you merge this pr. thanks

izouxv commented 1 year ago

@twiss thank you

izouxv commented 1 month ago

@twiss please check again. thank you

twiss commented 1 month ago

@izouxv You ignored all the comments that are hidden by default, you need to click "Load more..." or check the Files tab.

izouxv commented 1 month ago

@twiss please check again. thank you

twiss commented 1 month ago

This comment was not addressed. I know it didn't exist at the time this PR was opened, so I apologize for the churn, but all new functionality should go in the openpgp/v2 package. Please move the changes (except those in openpgp/packet) there, if you can.

izouxv commented 1 month ago

@twiss please check again. thank you

izouxv commented 1 month ago

This comment was not addressed. I know it didn't exist at the time this PR was opened, so I apologize for the churn, but all new functionality should go in the openpgp/v2 package. Please move the changes (except those in openpgp/packet) there, if you can.

ok

izouxv commented 1 month ago

@twiss please check again. thank you

izouxv commented 1 month ago

@twiss please check again. thank you

izouxv commented 1 month ago

@twiss HI,When can this be merged?

twiss commented 1 month ago

In addition to the above, could you please write a brief summary of the changes and additions to the API in the PR description, so that I can include it in the commit message? Currently it's very vague.

izouxv commented 1 month ago

In addition to the above, could you please write a brief summary of the changes and additions to the API in the PR description, so that I can include it in the commit message? Currently it's very vague.

ok

izouxv commented 1 month ago

@twiss please check again. thank you

twiss commented 1 month ago

@izouxv where did you add the description? :s

izouxv commented 1 month ago

@twiss please check again. thank you.
pr commit is: [feat](feat: Add AddPhotos to v2 api.)

izouxv commented 3 weeks ago

@twiss please check again. thank you.

twiss commented 3 weeks ago

Sorry, I meant more like: could you write a short description of the functions you added and what they're for? See https://github.com/ProtonMail/go-crypto/commit/8b3893ee7fca8cf2f8ab27de531011586c2f7b0d for a random (unrelated) example.

izouxv commented 3 weeks ago

Sorry, I meant more like: could you write a short description of the functions you added and what they're for? See 8b3893e for a random (unrelated) example.

my desc is : feat: Add Entity.AddPhotos function to v2 This change introduces a new function, Entity.AddPhotos, and the Entity struct adds a new member variables "Attributes". this enables user avatars encoded in jpeg format please check , thank you

izouxv commented 3 weeks ago

@twiss please check again. thank you.

izouxv commented 1 week ago

@twiss please check again. thank you.

izouxv commented 1 day ago

@twiss @lubux can you check the pr. thank you