ProtonMail / ios-mail

Secure email that protects your privacy
http://proton.me
GNU General Public License v3.0
1.42k stars 205 forks source link

Unable to Clone Networking library #39

Open nivritgupta opened 3 years ago

nivritgupta commented 3 years ago

i am getting following error when trying to clone these two frameworks .

Please make sure you have the correct access rights and the repository exists. fatal: clone of 'git@gitlab.protontech.ch:apple/shared/pmnetworking' into submodule path '/Users/developer/ios-mail/Networking' failed Failed to clone 'Networking'. Retry scheduled Cloning into '/Users/developer/ios-mail/Networking'...

iMonZ commented 3 years ago

is there anything new here? :(

jingx23 commented 3 years ago

If you change the networking submodule to https://github.com/ProtonMail/ios-networking you can somehow compile it at least to that point that it fails with:

ld: framework not found Crypto
clang: error: linker command failed with exit code 1 (use -v to see invocation)
nivritgupta commented 2 years ago

@iMonZ use ssh option when cloning the code, don't use HTTPS .

nivritgupta commented 2 years ago

hey, @zhj4478 @wussler I have a question, why is your protonmail ios app not using GopenPGP library?

wussler commented 2 years ago

The application does use GopenPGP for almost all purposes. Unfortunately generating RSA keys in go is too slow with gomobile (would take some minutes each key) therefore only to generate RSA keys we used this old library. This is being phased out as we move to ECC keys.