ProtonMail / ios-mail

Secure email that protects your privacy

http://proton.me

GNU General Public License v3.0

1.42k stars 205 forks source link

Fix multistage text input issue #72

Closed myihsan closed 11 months ago

myihsan commented 11 months ago

Problem

Using the range before clone it will break multistage text input in iOS 17.

Solution

Clone the range first.

Risk

I am an iOS developer unfamiliar with JavaScript, so I am unsure if this is a perfect solution. But it seems promising to me.

Related Problem Report

2430943

xavigil commented 11 months ago

Hey @myihsan , thanks for the PR.

Indeed this fixes a bug in Proton 4.8.0. Your change has been accepted and the patch has been merged in our development repository for the next release 4.9.0

Soon we will publish that version in the App Store and Github, stay tuned.

For now I will close this PR

Regards