search

ProtonMail / libsieve-php

libsieve-php is a library to manage and modify sieve (RFC5228) scripts. It contains a parser for the sieve language (including extensions) and a client for the managesieve protocol. It is written entirely in PHP 8+.
https://packagist.org/packages/protonlabs/libsieve-php
GNU General Public License v3.0
22 stars 7 forks source link

Add :create argument to fileinto #32

Closed wiktor-k closed 2 years ago

wiktor-k commented 2 years ago

This patch adds :create argument to fileinto through the mailbox extension.

See: https://www.rfc-editor.org/rfc/rfc5490.html#section-3.2

wiktor-k commented 2 years ago

Hi, is there anything I could do to help with merging this PR?

donataso commented 2 years ago

Hi Wiktor, thanks for the contribution. Could you please explain the motivation behind this change? I assume it may one of these two cases:

If it's the first case, then sadly it will not affect the way ProtonMail handles fileinto as this library is only used to parse sieve, but not act on the parsing results. We are not planning to work on this feature any time soon.

Have a nice day! Donatas

wiktor-k commented 2 years ago

Hi @donataso! 👋.

Fortunately this is the second case: I'm using this library to validate my sieve scripts that I'm using with Dovecot. I've found out that the library fails to parse one of my scripts and thought I could extend it (since this is open source!). Libsieve is great for linting scripts in CI for me so I hope it won't be a problem to merge this for you (as PM is not supporting this extension).

Have a nice day too!

donataso commented 2 years ago

Looks good then, thanks for the improvement.

wiktor-k commented 2 years ago

Thanks for your time!