search

ProtonMail / proton-bridge

Proton Mail Bridge application
GNU General Public License v3.0
1.17k stars 157 forks source link

Linux/Gnome AppIndicator icon creates empty space #294

Closed enewbury closed 1 year ago

enewbury commented 2 years ago

Expected Behavior

When unlocking computer, the protonmail appindicator should remain in the tray with no empty spaces

Current Behavior

Every time the computer is unlocked after sleep, an empty space is created in the tray (common Gnome Desktop Environment extension AppIndicators and KStatusNotifierItem Support Screenshot from 2022-09-07 11-47-17

The issue compounds itself because every subsquent unlock creates an additional new space, making a computer restart required or the tray overflows and becomes useless.

Possible Solution

Steps to Reproduce

  1. Running Fedora 36, Gnome Desktop w/ Wayland, AppIndicators extension
  2. Installed Protonmail (via Flatpak)
  3. Close the laptop lid
  4. Open laptop and log in w/ passoword
  5. See extra space created in tray
  6. Close again and repeat, see additional space created each time.

Version Information

2.2.2 and all previous versions. | Linux Flatpak (and RPM)

Context (Environment)

AppIndicators are probably the most common extension on Gnome since it allows me to see apps running in the background, and because this is a compounding issue where a new space is created every time the computer sleeps, it renders my tray useless after a few hours in the day, requiring a restart. The issue has been so bothersome, that I've been unable to use the bridge at all for the last year. I hoped with the major release this issue would be fixed, but unfortunately it seems the time has come to officially report it.

Detailed Description

Possible Implementation

A6GibKm commented 1 year ago

App indicators and wayland are more or less incompatible, so that might be causing the issue.

enewbury commented 1 year ago

Huh, surprised to hear that, I've been using apps like 1password, element, slack, nextcloud, and others on gnome Wayland with appindicators and haven't had any problems. Any idea how they could be making it work?

A6GibKm commented 1 year ago

Because some parts of it might work, but others might not, you just got lucky.

LBeernaertProton commented 1 year ago

@enewbury In 3.2.0 we replaced the context menu with a native implementation. Does that fix the problem for you?

A6GibKm commented 1 year ago

What does native implementation mean?

LBeernaertProton commented 1 year ago

Previously the context menu was written using QML. In 3.2.0 we switched to QWidgets (native), which better resembles the native style context menu for the OS.

enewbury commented 1 year ago

Hey @LBeernaertProton , sorry I've not been using linux for a while b/c work requirements, but I just popped it up, got everything updated, and confirming the issue is resolved with the new implementation! Thanks ya'll!