search

ProtonMail / proton-bridge

Proton Mail Bridge application
GNU General Public License v3.0
1.11k stars 145 forks source link

Remove spaces in startup .desktop file #468

Open gudvinr opened 3 months ago

gudvinr commented 3 months ago

Expected Behavior

.desktop file created by proton-bridge in .config/autostart/ should not contain space symbols.

Current Behavior

proton-bridge creates file named 'Proton Mail Bridge.desktop'.

Version Information

v3.9.1

Context (Environment)

In Linux, application startup done by placing .desktop files into .config/autostart/. proton-bridge does that too.

However, here and there different apps don't behave well when path to file contains whitespace symbols. While it isn't an issue with an app itself, that still creates issues that might affect users unexpectedly.

For example, I recently found an issue in Plasma which can be fixed by just renaming .desktop file.

Problem is, proton-bridge re-creates its desktop file on each startup, if not present. So you can't have both "Open on startup" enabled and working KCM.

Possible Implementation

This should be pretty simple.
Instead of Proton Mail Bridge.desktop file could be named proton-bridge.desktop, for example.

In fact, .desktop file in dist/ folder already named exactly like that. So, this also adds consistency.